Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front of House table A11y updates #4490

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Front of House table A11y updates #4490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc3e21
b-#4055 Front of House tables a11y updates with comments
StephDriver Nov 14, 2024
95c758a
b-#4055 Front of House tables a11y update
StephDriver Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions src/themes/OLH/templates/elements/section_block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,49 +2,45 @@ <h3>{% trans 'Sections' %}</h3>
<table>
<thead>
<tr>
<th>
<p>{% trans "Section or article type" %}</p>
</th>
<th>
<p>{% trans "Public Submissions" %}</p>
</th>
<th>
<p>{% trans "Peer Reviewed" %}</p>
</th>
<th>
<p>{% trans "Indexed" %}</p>
</th>
<th scope="col" >{% trans "Section or article type" %}</th>
<th scope="col" >{% trans "Public Submissions" %}</th>
<th scope="col" >{% trans "Peer Reviewed" %}</th>
<th scope="col" >{% trans "Indexed" %}</th>
</thead>
<tbody>
{% for section in sections %}
<tr>
<td>
<p>{{ section.name }}</p>
</td>
<th scope="row" >{{ section.name }}</th>
<td>
<strong>
{% if section.public_submissions %}
<i class="fa fa-check" title="{% trans 'yes' %}"></i>
<i aria-hidden="true" class="fa fa-check"></i>
<span class="sr-only">{% trans 'has public submissions' %}</span>
{% else %}
<i class="fa fa-times" title="{% trans 'no' %}"></i>
<i aria-hidden="true" class="fa fa-times"></i>
<span class="sr-only">{% trans 'does not have public submissions' %}</span>
{% endif %}
</strong>
</td>
<td>
<strong>
{% if section.number_of_reviewers > 0 %}
<i class="fa fa-check" title="{% trans 'yes' %}"></i>
<i aria-hidden="true" class="fa fa-check"></i>
<span class="sr-only">{% trans 'is peer reviewed' %}</span>
{% else %}
<i class="fa fa-times" title="{% trans 'no' %}"></i>
<i aria-hidden="true" class="fa fa-times"></i>
<span class="sr-only">{% trans 'is not peer reviewed' %}</span>
{% endif %}
</strong>
</td>
<td>
<strong>
{% if section.indexing %}
<i class="fa fa-check" title="{% trans 'yes' %}"></i>
<i aria-hidden="true" class="fa fa-check"></i>
<span class="sr-only">{% trans 'is indexed' %}</span>
{% else %}
<i class="fa fa-times" title="{% trans 'no' %}"></i>
<i aria-hidden="true" class="fa fa-times"></i>
<span class="sr-only">{% trans 'is not indexed' %}</span>
{% endif %}
</strong>
</td>
Expand Down
12 changes: 6 additions & 6 deletions src/themes/clean/templates/elements/sections_block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,22 @@ <h2>{% trans 'Sections' %}</h2>
<caption>{% trans 'Sections submission information' %}</caption>
<thead>
<tr>
<th>{% trans 'Section or article type' %}</th>
<th>{% trans 'Public Submissions' %}</th>
<th>{% trans 'Peer Reviewed' %}</th>
<th>{% trans 'Indexed' %}</th>
<th scope="col">{% trans 'Section or article type' %}</th>
<th scope="col">{% trans 'Public Submissions' %}</th>
<th scope="col">{% trans 'Peer Reviewed' %}</th>
<th scope="col">{% trans 'Indexed' %}</th>
</tr>
</thead>
<tbody>
{% for section in sections %}
<tr>
<td>{{ section.name }}</td>
<th scope="row">{{ section.name }}</th>
<td>{% if section.public_submissions %}<span class="fa fa-check"> {% trans 'Yes' %}</span>{% else %}
<span class="fa fa-times"> {% trans 'No' %}</span>{% endif %}</td>
<td>{% if section.number_of_reviewers > 0 %}<span class="fa fa-check"> {% trans 'Yes' %}</span>{% else %}
<span class="fa fa-times"> {% trans 'No' %}</span>{% endif %}</td>
<td>{% if section.indexing %}<span class="fa fa-check"> {% trans 'Yes' %}</span>{% else %}
<span class="fa fa-times"> {% trans 'No' %}}</span>{% endif %}</td>
<span class="fa fa-times"> {% trans 'No' %}</span>{% endif %}</td>
</tr>
{% empty %}
{% endfor %}
Expand Down
20 changes: 5 additions & 15 deletions src/themes/material/templates/elements/sections_display.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,15 @@
<table class="striped responsive-table">
<thead>
<tr>
<th>
<p>{% trans "Section or article type" %}</p>
</th>
<th>
<p>{% trans "Public Submissions" %}</p>
</th>
<th>
<p>{% trans "Peer Reviewed" %}</p>
</th>
<th>
<p>{% trans "Indexed" %}</p>
</th>
<th scope="col">{% trans "Section or article type" %}</th>
<th scope="col">{% trans "Public Submissions" %}</th>
<th scope="col">{% trans "Peer Reviewed" %}</th>
<th scope="col">{% trans "Indexed" %}</th>
</thead>
<tbody>
{% for section in sections %}
<tr>
<td>
<p>{{ section.name }}</p>
</td>
<th scope="row">{{ section.name }}</th>
<td>
<strong>
{% if section.public_submissions %}
Expand Down
16 changes: 8 additions & 8 deletions src/themes/material/templates/journal/article.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,49 +309,49 @@ <h4>{% trans "Publication details" %}</h4>
<table class="sidebar-table">
{% if article.page_range %}
<tr>
<th>{% trans "Pages" %}</th>
<th scope="row" >{% trans "Pages" %}</th>
<td>{{ article.page_range }}</td>
</tr>
{% endif %}
{% if article.article_number %}
<tr>
<th>{% trans "Article No." %}</th>
<th scope="row" >{% trans "Article No." %}</th>
<td>{{ article.article_number }}</td>
</tr>
{% endif %}
{% if article.publisher_name %}
<tr>
<th>{% trans "Publisher" %}</th>
<th scope="row" >{% trans "Publisher" %}</th>
<td>{{ article.publisher_name }}</td>
</tr>
{% endif %}
{% if article.publication_title %}
<tr>
<th>{% trans "Publication" %}</th>
<th scope="row" >{% trans "Publication" %}</th>
<td>{{ article.publication_title }}</td>
</tr>
{% endif %}
{% if article.ISSN_override %}
<tr>
<th>{% trans "Original ISSN" %}</th>
<th scope="row" >{% trans "Original ISSN" %}</th>
<td>{{ article.ISSN_override}}</td>
</tr>
{% endif %}
{% if journal_settings.article.display_date_submitted and article.date_submitted %}
<tr>
<th>{% trans "Submitted on" %}</th>
<th scope="row" >{% trans "Submitted on" %}</th>
<td>{{ article.date_submitted|date:"Y-m-d" }}</td>
</tr>
{% endif %}
{% if journal_settings.article.display_date_accepted and article.date_accepted %}
<tr>
<th>{% trans "Accepted on" %}</th>
<th scope="row" >{% trans "Accepted on" %}</th>
<td>{{ article.date_accepted|date:"Y-m-d" }}</td>
</tr>
{% endif %}
{% if article.date_published or proofing %}
<tr>
<th>{% trans "Published on" %}</th>
<th scope="row" >{% trans "Published on" %}</th>
<td id="article_date_published">
{{ article.date_published|date:"Y-m-d" }}
</td>
Expand Down