Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified style and accessibility upgrades for login, registration, and profile pages #4491

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joemull
Copy link
Member

@joemull joemull commented Nov 15, 2024

Closes #4380.

Implementation notes

  • Brought all pages where a user manages their own account into the back office, and deprecated the theme templates
  • Adjusted the admin base as needed to handle unauthenticated users
  • Implemented a contextual title element so that the relevant site name is appropriately provided in addition to the page title
  • Wrote view tests to make sure new templates are hit
  • Used "secondary" style buttons for accessibility (color contrast)
  • Adjusted link colors for accessibility (color contrast)
  • Improved form accessibility in a few places
  • Made heading structure consistent, though I would have preferred not to use h2 for these elements (h1 is taken by the header and used for the site title, which is not ideal in my opinion)

Limitations

  • We have got to sort out the heading structure in core/base.html -- it results in two h1s in most cases, and one of them is often empty. My preference is that h1 is used for the actual page, not the site name, and that the site name is simply appended to the title element, so it is available in the browser tab.
  • The interests field is a consistent accessibility trap, until we can get away from jquery / tagit. We may be able to re-implement this bit of the page as a Django formset

Screenshot_20241115_164725
Screenshot_20241115_164748
Screenshot_20241115_164758
Screenshot_20241115_164806
Screenshot_20241115_164832
Screenshot_20241115_164857
Screenshot_20241115_164957
Screenshot_20241115_165013
Screenshot_20241115_165050
Screenshot_20241115_165123
Screenshot_20241115_165141
Screenshot_20241115_165210
Screenshot_20241115_165224
Screenshot_20241115_165430
Screenshot_20241115_165509
Screenshot_20241115_165826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring authentication and account pages into back office
2 participants