Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Fix For Control Statements. #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SJBaroi
Copy link
Contributor

@SJBaroi SJBaroi commented Mar 10, 2022

What type of PR is this?

Code Review Fix For Control Statements.
/kind task

What does this PR do / why do we need it:

Code Review Fix For Control Statements - use of for each loop instead of traditional for loop if index are not required.
Rule 8.3.1.

Which issue(s) this PR fixes:

Fixes #312

Special notes for your reviewers:

@it-is-a-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SJBaroi
To complete the pull request process, please assign lizheng920625
You can assign the PR to them by writing /assign @lizheng920625 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nitin-Kashyap
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Review Comments For Log And Control Statements
3 participants