Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Fix for Naming #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shalumariamsheji
Copy link

What type of PR is this?

Code Review fix for Naming Convention

What does this PR do / why do we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

@it-is-a-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shalumariamsheji
To complete the pull request process, please assign lizheng920625
You can assign the PR to them by writing /assign @lizheng920625 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@it-is-a-robot
Copy link
Contributor

Welcome @shalumariamsheji!

It looks like this is your first PR to openlookeng/hetu-core 🎉.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if openlookeng/hetu-core has its own contribution guidelines. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to MindSpore. 😃

@shalumariamsheji shalumariamsheji marked this pull request as ready for review March 22, 2022 04:03
@Nitin-Kashyap
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants