-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
288 Enable COBOL Check to issue warnings/errors when a call statement is not mocked. #316
Changes from all commits
2763289
a10fd6d
1ce2140
0a0ceea
17e3a61
1b39e07
db030f1
77175ab
a581ec9
1787967
d79da9a
32eb3d1
21e36e2
55fd5d9
4ef2003
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package org.openmainframeproject.cobolcheck.exceptions; | ||
|
||
public class UnMockedCallStatementException extends RuntimeException { | ||
public UnMockedCallStatementException(String message) { | ||
super(message); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ ERR029 = ERR029: NumericFields.setDataTypeOf() was called with null dataType. | |
ERR030 = ERR030: Command line missing program argument '-p programName' . | ||
ERR031 = ERR031: A test suite with the name %1$s already exists. | ||
ERR032 = ERR032: A test case with the name %1$s already exists in the test suite %2$s. | ||
ERR033 = ERR033: Call Statement in Line %1$s of the source code is not mocked in %2$s of testSuite %3$s. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please change to "not mocked in testcase "%2$s" " to indicate that the first value is the testcase. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Rune-Christensen https://github.com/openmainframeproject/cobol-check/pull/316/files#diff-9d10e676c4992827a0cac77d70a1d1b995c80694ad957793df629043a5121121R154 |
||
|
||
WRN001 = WRN001: No test suite directory for program %1$s was found under directory %2$s. | ||
WRN002 = WRN002: No test suite files were found under directory %1$s. | ||
|
@@ -41,6 +42,7 @@ WRN005 = WRN005: Test results input file not found: %1$s. Define in config as te | |
WRN006 = WRN006: IOException writing test results to file: %1$s in ProcessOutputWriter.writeProcessOutputToFile(...) | ||
WRN007 = WRN007: IOException reading test results from current process | ||
WRN008 = WRN008: Access denied: Could not change permissions for %1$s | ||
WRN009 = WRN009: Call Statement in Line %1$s of the source code is not mocked in %2$s of testSuite %3$s. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, thank you |
||
|
||
INF001 = INF001: Attempting to load config from %1$s. | ||
INF002 = INF002: Loaded config successfully from %1$s. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to ask for some rewriting here.
TestSuiteParser is a feature in the structure of COBOL Check.
As general rule, features should not be importing features.
I know there are exceptions to that, but it is not the case for TestSuiteParser.
You should be able to get the values you are looking for, from a services, instead of a feature.
Thank you