Fix memory resize failure due to not aligned to 256M #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code caculates an active VM's memory with the Total online memory value of `lsmem` command output when doing live resize. This value is in Gigabytes, and is not precise to 2 digits, for example, lsmem should be reporting 2.75G, but instead it reports 2.8G; when target memory is 4G, then the to-be-increased memory is caculated to 1.2G, which is not aligned to 256M, then causes resize to fail. To fix this problem, change to use the `lsmem -b` output, as it is in Bytes, so it is precise value, and always be aligned to 256M. Signed-off-by: Shu Juan Zhang <[email protected]>
SeanHQF
approved these changes
Feb 29, 2024
|
/lgtm |
haoxy000
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code caculates an active VM's memory with the Total online memory value of
lsmemcommand output when doing live resize.This value is in Gigabytes, and is not precise to 2 digits, for example, lsmem should be reporting 2.75G, but instead it reports 2.8G; when target memory is 4G, then the to-be-increased memory is caculated to 1.2G, which is not aligned to 256M, then causes resize to fail.
To fix this problem, change to use the
lsmem -boutput, as it is in Bytes, so it is precise value, and always be aligned to 256M.