notfound_fcps_are_not_counted_in_fcp_template_detail_api #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackydalong
commented
Apr 10, 2024
| @@ -1832,7 +1849,6 @@ def get_fcp_templates_details(self, template_id_list=None, raw=False, | |||
| self._sync_db_with_zvm() | |||
| statistics_usage = {} | |||
| raw_usage = {} | |||
| template_info = {} | |||
There was a problem hiding this comment.
the template_info is not used, so remove it
jackydalong
force-pushed
the
notfound_fcps_are_not_counted_in_fcp_template_detail_api
branch
5 times, most recently
from
205aabf
to
5f677cf
Compare
For fcp devices that are not found in z/VM LPAR, they are not counted in the total_count of response of fcp template detail api. The PR is to adding count of those fcp devices in total_count of the API response Signed-off-by: Da Long Wang <[email protected]>
jackydalong
force-pushed
the
notfound_fcps_are_not_counted_in_fcp_template_detail_api
branch
from
5f677cf
to
93f38ea
Compare
bjhuangr
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fcp devices that are not found in z/VM LPAR,
they are not counted in the total_count of response of fcp template detail api.
The PR is to adding count of those fcp devices in total_count of the API response