Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Installation instructions for SLES #829

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Docs: Installation instructions for SLES #829

merged 1 commit into from
Aug 14, 2024

Conversation

aazam-gh
Copy link
Contributor

Updated setuphttpd.rst to include installation instructions for SLES

Bischoff
Bischoff reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good first draft, thank you.

See the remarks. The update to 15.5 is painful, but we need to do it.

doc/source/setuphttpd.rst Outdated Show resolved Hide resolved
doc/source/setuphttpd.rst Outdated Show resolved Hide resolved
@aazam-gh aazam-gh force-pushed the webserver-sles branch 2 times, most recently from 0ce2ff8 to 4640a36 Compare June 24, 2024 08:50
@bjhuangr
Copy link
Contributor

bjhuangr commented Jul 9, 2024

@aazam-gh still work in progress?

@aazam-gh
Copy link
Contributor Author

aazam-gh commented Jul 9, 2024

@bjhuangr Yes, will be ready soon after testing on z/VM

mfriesenegger
mfriesenegger requested changes Aug 8, 2024
View reviewed changes
doc/source/setuphttpd.rst Outdated
@@ -34,7 +34,7 @@ The last section of this chapter details about using tokens to enhance security.
Tested RHEL 9.4 SLES 15.5 Ubuntu 24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tested RHEL 9.4 SLES 15.5 Ubuntu 24.04
Tested RHEL 9.4 SLES 15 SP5 Ubuntu 24.04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

doc/source/setuphttpd.rst
Comment on lines +90 to +95
Install the downloaded packages using the `zypper` command

..code-block:: text

# zypper install zthin-<version>-<release>.s390x.rpm
# zypper install zvmsdk-<version>-<release>.noarch.rpm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed because the zypper install command is included in the quickstart section?

Copy link
Contributor

@Bischoff Bischoff Aug 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to duplicate that piece of information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now in the current PR, keep the change as is.
As it is already present in the previous page, rather have the commands about starting/stopping the web server, which can be handled in a new PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

By the way, it seems to me that, when you install from packages, apache2 is automatically started, so you don't need instructions to start it in that specific case.

But maybe I'm starting to overthink it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are thinking correctly but it does not hurt to restate that apache2 might need to be restarted.

Bischoff
Bischoff suggested changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see last remarks

doc/source/setuphttpd.rst Outdated
@@ -34,7 +34,7 @@ The last section of this chapter details about using tokens to enhance security.
Tested RHEL 9.4 SLES 15.5 Ubuntu 24.04
====================== ================= ================= =================
Apache2 + uwsgi ✓
Apache2 + mod_wsgi ✓
Apache2 + mod_wsgi ✓ ✓
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use three check marks on this line, we now also do Ubuntu with the mod_wsgi module for Apache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's 2 check marks now, not 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

doc/source/setuphttpd.rst
@@ -34,7 +34,7 @@ The last section of this chapter details about using tokens to enhance security.
Tested RHEL 9.4 SLES 15.5 Ubuntu 24.04
====================== ================= ================= =================
Apache2 + uwsgi ✓
Apache2 + mod_wsgi ✓
Apache2 + mod_wsgi ✓ ✓
nginx + uwsgi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check mark in "Ubuntu" column for nginx + uwsgi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

doc/source/setuphttpd.rst Outdated
@@ -82,7 +82,33 @@ To change that, you need to modify both Apache configuration and firewall rules.
SUSE Linux Enterprise Server
----------------------------

(to be written).
The following instructions are for SLES15 SP5.
The RPM packages can be downloaded from (to be determined).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put download URL here (from Virtualisation:feilong)

same for RHEL, BTW

please check there are no more (to be determined) remarks 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aazam-gh aazam-gh changed the title WIP: Docs: Installation instructions for SLES Docs: Installation instructions for SLES Aug 13, 2024
@aazam-gh aazam-gh force-pushed the webserver-sles branch 4 times, most recently from d9b1207 to b590805 Compare August 13, 2024 12:09
@mfriesenegger
Copy link
Contributor

@bjhuangr This is ready to be merged.

@bjhuangr bjhuangr merged commit 4c56153 into openmainframeproject:master Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfriesenegger mfriesenegger mfriesenegger requested changes

@Bischoff Bischoff Bischoff requested changes

@bjhuangr bjhuangr bjhuangr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aazam-gh @bjhuangr @mfriesenegger @Bischoff