Docs: Updated quickstart with OBS Package install for RPM and SLES #835
Conversation
|
|
||
| 2. Disable gpgkeycheck flag | ||
|
|
||
| Add the flag `gpgkeycheck=0`to the /etc/yum.repos.d/download.opensuse.org_repositories_Virtualization_feilong_AlmaLinux_9_.repo file. |
There was a problem hiding this comment.
formatting problem here (the hyperlink)
please ignore if doc generation does not have the problem (ie if it's only a problem with github's rendering)
|
|
||
| Update the config file `/etc/selinux/config` and set `SELINUX=disabled`. | ||
| Make sure you reboot to ensure the changes are reflected and SELinux is disabled. | ||
| We are considering writing SELinux policies for Feilong that would enable to not disable SELinux as a whole. |
There was a problem hiding this comment.
empty line before that one?
There was a problem hiding this comment.
The line after the sub heading? It is the same format as the rest
There was a problem hiding this comment.
I was suggesting to add a blank line before "We are considering writing"
doc/source/quickstart.rst
Outdated
|
|
||
| .. code-block:: text | ||
|
|
||
| # zypper ar https://download.opensuse.org/repositories/Virtualization:/feilong/15.5/ feilong |
There was a problem hiding this comment.
I think it's called "SLE_15_SP5" now instead of "15.5"
correct link: https://download.opensuse.org/repositories/Virtualization:/feilong/SLE_15_SP5/
aazam-gh
force-pushed
the
quickstartdocs
branch
from
15a89ac
to
f872508
Compare
doc/source/quickstart.rst
Outdated
| 3. Disable SELinux | ||
|
|
||
| Make sure SELinux is set to disabled mode. | ||
| We are considering writing SELinux policies for Feilong that would enable to not disable SELinux as a whole. |
There was a problem hiding this comment.
? I think you can remove this whole paragraph. By default, SLES uses apparmor, not SELinux.
(unless you have seen SELinux on SLES on linux 1 VM?)
There was a problem hiding this comment.
Yes SLES indeed uses apparmor on L1CC as well. Removing the entire paragraph
aazam-gh
force-pushed
the
quickstartdocs
branch
from
f872508
to
3ad7ed6
Compare
| it might be changed and for now please install through code directly. | ||
|
|
||
| 2. **Through Source Code directly** | ||
|
|
There was a problem hiding this comment.
Instead of removing paragraph 1, say we now have packages, maybe?
There was a problem hiding this comment.
or this is done above? i'm getting a bit lost
There was a problem hiding this comment.
Instead of removing paragraph 1, say we now have packages, maybe?
I am OK with removing these lines versus repeating a statement that packages exist. The Installation using OBS Packages section is before the Manual Installation so a reader hopefully will have seen that packages exist.
There was a problem hiding this comment.
Fine :)
Then please ignore Aazam.
| Debian for Ubuntu | ||
| ----------------- | ||
|
|
||
| (to be continued) |
There was a problem hiding this comment.
this could be updated now?
There was a problem hiding this comment.
then please ignore Aazam.
aazam-gh
force-pushed
the
quickstartdocs
branch
from
3ad7ed6
to
0cce22f
Compare
|
Changes have been done. Ready for Merge :) |
doc/source/quickstart.rst
Outdated
|
|
||
| 4. Skip to the SSH key authentication between consumer and BYOL section to continue. | ||
|
|
||
| Debian for Ubuntu |
There was a problem hiding this comment.
| Debian for Ubuntu | |
| DEB for Ubuntu |
There was a problem hiding this comment.
I think "DEB" could be all lowercase but I am suggesting all uppercase like has been done with RPM for RH and SLES.
aazam-gh
force-pushed
the
quickstartdocs
branch
2 times, most recently
from
878fbad
to
4aa9a6f
Compare
|
@bjhuangr This is ready to be merged. |
Signed-off-by: aazam <[email protected]>
bjhuangr
force-pushed
the
quickstartdocs
branch
from
4aa9a6f
to
b372735
Compare
Updated
quickstart.rstPR forwarded from #832