-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update webserver setup instructions #838
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpicks
doc/source/setuphttpd.rst
Outdated
@@ -44,24 +44,10 @@ Installing from packages | |||
Redhat Enterprise Linux | |||
----------------------- | |||
|
|||
The following instructions are for RHEL 9.4. | |||
The following instructions are for RHEL 9.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep this end of sentence dot.
The RPM packages can be downloaded from https://download.opensuse.org/repositories/Virtualization:/feilong/AlmaLinux_9/ | ||
|
||
Before installing the necessary packages, it is important to set up the EPEL repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a final dot at end of sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not confuse the readers with entering a dot at the end of the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on how it is rendered by the rst-to-html conversion.
What I usually do in such cases, to avoid such confusions, is to add as pace before the dot. Not ideal, but it separates the link and the punctuation.
Signed-off-by: aazam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The RPM packages can be downloaded from https://download.opensuse.org/repositories/Virtualization:/feilong/AlmaLinux_9/ | ||
|
||
Before installing the necessary packages, it is important to set up the EPEL repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on how it is rendered by the rst-to-html conversion.
What I usually do in such cases, to avoid such confusions, is to add as pace before the dot. Not ideal, but it separates the link and the punctuation.
Ready to merge |
Updated
setuphttpd.rst