Resize CPU with custom cpu share #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhosh-sloka
force-pushed
the
cpu_resize_with_share_enhancement
branch
3 times, most recently
from
da880af
to
336e562
Compare
Signed-off-by: santhosh-sloka <[email protected]>
santhosh-sloka
force-pushed
the
cpu_resize_with_share_enhancement
branch
from
336e562
to
b542e9f
Compare
bjhuangr
reviewed
Aug 20, 2024
| @@ -1005,7 +1005,7 @@ def guest_create(self, userid, vcpus, memory, disk_list=None, | |||
| rdomain, pcif) | |||
|
|
|||
| @check_guest_exist() | |||
| def guest_live_resize_cpus(self, userid, cpu_cnt): | |||
| def guest_live_resize_cpus(self, userid, cpu_cnt, cpu_share=''): | |||
There was a problem hiding this comment.
update feilong doc accoordingly for the new parameter
There was a problem hiding this comment.
sure @bjhuangr , will update the feilong doc as well
SeanHQF
approved these changes
Aug 20, 2024
bjhuangr
approved these changes
Aug 21, 2024
|
@santhosh-sloka please update the doc in another PR |
sure @bjhuangr ,Thanks i am working on it, will update the doc and raise the new PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The code will help successful CPU resize Operation by preserving the custom CPU share deployed by the customer.
Which issue(s) this PR fixes(unless minor typo change ,better to have an issue opened):
https://github.ibm.com/zvc/planning/issues/18693
Special notes for your reviewer:
There is a dependent PR for this in icic-dev repo, " https://github.ibm.com/zvc/icic-dev/pull/6088 " both of the PR's should be merged together
Results are attached here :
https://github.ibm.com/zvc/planning/issues/18693#issuecomment-88412796
https://github.ibm.com/zvc/planning/issues/18693#issuecomment-88412883
https://github.ibm.com/zvc/planning/issues/18693#issuecomment-88499911 << resize with VM shutdown
[optional] which components (compute, zvm/kvm etc)
zvm
[optional] backward incompatible change
[optional] security impact
[optional] open source package impact
--signed-off : [email protected] ( [email protected] )