Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error of variable referenced before assignment #841

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

zhshuj
Copy link
Contributor

@zhshuj zhshuj commented Aug 21, 2024

There are possibility of error
local variable 'codes' referenced before assignment
this commit is to fix it.

There are possibility of error
 local variable 'codes' referenced before assignment
this commit is to fix it.

Signed-off-by: Shu Juan Zhang <[email protected]>
@zhshuj
Copy link
Contributor Author

zhshuj commented Aug 21, 2024

@jichenjc @SeanHQF @bjhuangr could you please review?

@@ -573,6 +576,7 @@ def testMigrate(rh):
rh.printLn("ES", msg)
rh.updateResults(msgs.msg['0418'][0])
else:
codes = ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we didn't set at line 584, this means we will likely report empty value
is this expected or we say something (N/A or not able to find detailed error ) etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we didn't set at line 584, this means we will likely report empty value is this expected or we say something (N/A or not able to find detailed error ) etc?

When the codes is set , the printed message is like:
ULTMIG0420E An error occurred issuing a VMRELOCATE Move for userid COR10002. Please look up message(s): 1940 1937 in the CP Messages book for more information.']}'", 'output': ''}

codes are 1940 1937, which are returning CP messages error codes for VMRELOCATE command, and filled in the printed messages.

When codes is empty, the following messages are printed.

ULTMIG0420E An error occurred issuing a VMRELOCATE Move for userid COR10002. Please look up message(s): in the CP Messages book for more information.']}'", 'output': ''}

If still not clear enough, I can add info about not able to find detailed error

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good for me , thanks for the detailed msg

@jichenjc jichenjc merged commit a5ad286 into openmainframeproject:master Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants