Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for project driver-rocketmq had format violations #399

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

StevenLuMT
Copy link
Contributor

BUG REPORT

the condition that the bug triggers:
when install this project use this command mvn install

Describe the bug
Fixed for 'Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.25.0:check (check) on project driver-rocketmq: The following files had format violations: [ERROR] src/main/java/io/openmessaging/benchmark/driver/rocketmq/RocketMQBenchmarkDriver.java'

Screenshots
image

Suggestion
how to avoid the problem from happening again?
please execute this command mvn spotless:apply to format the code before push the commit

…n-plugin:2.25.0:check (check) on project driver-rocketmq: The following files had format violations: [ERROR] src/main/java/io/openmessaging/benchmark/driver/rocketmq/RocketMQBenchmarkDriver.java'
@StevenLuMT
Copy link
Contributor Author

@Jason918 @merlimat @eolivelli @teabot @codelipenghui
Help me review this pr, thanks

Copy link
Member

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sijie sijie merged commit f423781 into openmessaging:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants