Social media logos #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
reviewed
May 28, 2024
|
Okay that is just weird. It renders fine on my PC with no errors. Ill try and debug it. |
|
Does the action run parts from the main branch somehow? Because it seems the issue is that some of the new people in people.yml dont have the fields mail, linkedin etc, so the renderer doesnt find those attributes. I added them to my people.yml but somehow github doesnt see them? I am very confused right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added social media logos. the icons are not the best so feel free to change them/let me know what to change. check people.qmd and people.yml for changes.
re-did the PR because of extra aretfacts generated by Quarto.