Use CustomCPPForceImpl to simplify code #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peastman, I like this simplification of the plugin. I suppose this needs to wait until OpenMM 8.1 (with openmm/openmm#4231) is available. Otherwise, we can neither release the new version nor even CI testing. |
|
Correct. |
This was referenced Oct 9, 2023
|
Tests passed building against OpenMM 8.1. @raimis does it look good to you? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openmm/openmm#4231 introduced new infrastructure that lets us dramatically simplify plugins like this one. Instead of needing a separate plugin library for each platform, we just implement it once with platform-independent C++.