Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Separate linting and formatting concerns #51

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • I checked for feature overlap with existing widgets.

Summary

Our current setup is running Prettier as a part of ESLint. These are two separate concerns that should be handled separately by different tools.

This PR removes eslint-plugin-prettier and eslint-config-prettier from our linting config as recommended here and here. I've also separated ESLint concerns from Prettier so that ESLint doesn't handle both. The recommended modern approach treats Prettier and ESLint as separate unrelated tools.

I've also removed the prettier script from the root-level package.json to the lint-staged config so that lint-staged runs Prettier after ESLint.

Screenshots

None.

Issue

None.

Other

None.

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this involved no changes to the actual code!

@denniskigen
Copy link
Member Author

denniskigen commented Apr 9, 2024

That's because I've turned most everything off to keep the diff tight.

@denniskigen denniskigen merged commit e4d65a9 into main Apr 9, 2024
5 checks passed
@denniskigen denniskigen deleted the chore/tooling branch April 9, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants