-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3890 Help menu (and menu items) should use a standard Carbon… #1164
base: main
Are you sure you want to change the base?
Conversation
{t('docs', 'Docs')} | ||
</Link> | ||
label={t('documentation', 'Documentation')} | ||
onClick={() => window.open('https://o3-docs.openmrs.org', '_blank')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the onClick handler to a function that's wrapped in a useCallback hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn’t expect these changes to be included here. Bad rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a mistake on my end, I'll fix it
{t('communityforum', 'Community forum')} | ||
</Link> | ||
label={t('communityforum', 'Community forum')} | ||
onClick={() => window.open('https://talk.openmrs.org', '_blank')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wrap the onClick
handlers in use callback hooks? Additionally, for security, it’s good to add noreferrer noopener
to external links:
const handleClick = useCallback(() => {
window.open('https://talk.openmrs.org', '_blank', 'noopener,noreferrer');
}, [url]);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
@Samstar10 Are you planning on continuing work on this? When? Is it clear to you how to proceed? |
Hello @brandones , yes, I have already completed it actually, just having some troubles with pushing it, hoping to be helped during today's coffee break. |
Mind resolving the conflicts, @Samstar10? |
Yes, currently working on that. |
import { Link } from '@carbon/react'; | ||
|
||
const ContactUs = () => { | ||
const { t } = useTranslation(); | ||
return ( | ||
<Link | ||
className={styles.helpButton} | ||
style={{ textDecoration: 'none' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should move to styles.scss
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denniskigen for some reason whenever I move this to the styles.css it does not work. This is the only way it works.
import { Link } from '@carbon/react'; | ||
|
||
const Docs = () => { | ||
const { t } = useTranslation(); | ||
return ( | ||
<Link | ||
className={styles.helpButton} | ||
style={{ textDecoration: 'none' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@@ -10,6 +10,7 @@ const ReleaseNotes = () => { | |||
return ( | |||
<Link | |||
className={styles.helpButton} | |||
style={{ textDecoration: 'none' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
color: black !important; | ||
&:focus { | ||
outline: none; | ||
} | ||
} | ||
|
||
.helpButton:hover { | ||
background: #e8e8e8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background: #e8e8e8; | |
background: colors.$white-hover; |
https://carbon-elements.netlify.app/colors/examples/preview/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denniskigen this variable doesn't seem to exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,8 +6,13 @@ | |||
display: flex; | |||
align-items: center; | |||
justify-content: space-between; | |||
padding: 0.5rem 0.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding: 0.5rem 0.5rem; | |
padding: layout.$spacing-03; |
nit: padding: layout.spacing-03
is shorthand for padding-top: 0.5rem; padding-right: 0.5rem; padding-bottom: 0.5rem; padding-left: 0.5rem
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we deleting this file? Seems unrelated to whatever else we're doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to sort out the bad rebase. Working on fixing it now.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
I have updated the help menu to use standard carbon menu items. This PR is related to this PR openmrs/openmrs-esm-user-onboarding#21
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3890
Other