Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3888: Tweak help menu hover state #1179

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

elishabantana
Copy link
Contributor

@elishabantana elishabantana commented Oct 15, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

I have changed the cursor of the help menu to a pointer and applied a gray background on hover.

Screenshots

https://www.loom.com/share/0812485b5b9144fdb452888c1c450fde?sid=412f01f6-a1bb-4ebf-bd43-c5bf33ae2b0a

Related Issue

https://openmrs.atlassian.net/browse/O3-3888

Other

@denniskigen denniskigen changed the title (fix) O3-3888 Help menu needs a hover state and correct (interactive) cursor (fix) O3-3888: Tweak help menu hover state Oct 16, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @elishabantana!

@denniskigen denniskigen merged commit 602cc03 into openmrs:main Oct 16, 2024
12 of 14 checks passed
@elishabantana
Copy link
Contributor Author

elishabantana commented Oct 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants