Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Make side-nav scrollable #732

Merged
merged 1 commit into from
Jul 24, 2023
Merged

(feat) Make side-nav scrollable #732

merged 1 commit into from
Jul 24, 2023

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented Jul 14, 2023 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

  • Makes the side nav scrollable

Screenshots

Related Issue

Other

Related to openmrs/openmrs-esm-patient-chart#1230

@Jexsie Jexsie mentioned this pull request Jul 14, 2023
Merged
3 tasks
@Jexsie Jexsie changed the title (feat) Make side-nav scollable (feat) Make side-nav scrollable Jul 17, 2023
pirupius
pirupius approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pirupius pirupius merged commit 8c423da into openmrs:main Jul 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jexsie @pirupius