(feat) Update type LoggedInUser to list userProperties in use #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -211 kB (-9%) ✅ Total Size: 2.13 MB
ℹ️ View Unchanged
|
ibacher
changed the title
ibacher
approved these changes
Aug 10, 2023
| @@ -13,7 +13,23 @@ export interface LoggedInUser { | |||
| display: string; | |||
| username: string; | |||
| systemId: string; | |||
| userProperties: { [key: string]: any } | null; | |||
| userProperties: { | |||
There was a problem hiding this comment.
So, the one thing I'm noticing is that these comments for named properties don't appear in the autogenerated docs, which is a bit unfortunate, but this is overall a big improvement.
denniskigen
reviewed
Aug 10, 2023
| userProperties: { | ||
| /** | ||
| * The UUIDs of patients the user has visited | ||
| * Seprataed by commas |
There was a problem hiding this comment.
Suggested change
| * Seprataed by commas | |
| * Separated by commas |
denniskigen
reviewed
Aug 10, 2023
| patientsVisited?: string; | ||
| /** | ||
| * The UUIDs of patient lists the user has starred | ||
| * Seprataed by commas |
There was a problem hiding this comment.
Suggested change
| * Seprataed by commas | |
| * Separated by commas |
denniskigen
approved these changes
Aug 10, 2023
denniskigen
approved these changes
Aug 10, 2023
denniskigen
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This PR updates the
LoggedInUsertype to store the already used keys in other apps for better understandinguser.userProperties.patientsVisitedused in the patient search for storing patients visited by the useruser.userProperties.starredPatientListsto be used in the patient list app to store the UUIDs of the patient lists starred by the user.Screenshots
None
Related Issue
Other