Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Resolve template literals in the src prop of the logo config #749

Merged
merged 2 commits into from
Sep 14, 2023
Merged

(feat) Resolve template literals in the src prop of the logo config #749

merged 2 commits into from
Sep 14, 2023

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Ensures that any encountered template literals within logo.src are resolved if supported.

@samuelmale samuelmale requested review from brandones, FlorianRappl and pirupius and removed request for FlorianRappl August 15, 2023 12:49
@brandones
Copy link
Collaborator

Code looks good but please fix the tests.

@denniskigen denniskigen changed the title Resolve template literals in the src prop of the logo config (feat) Resolve template literals in the src prop of the logo config Sep 14, 2023
denniskigen
denniskigen approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @samuelmale!

@denniskigen denniskigen merged commit 1f197d6 into openmrs:main Sep 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandones brandones brandones approved these changes

@denniskigen denniskigen denniskigen approved these changes

@pirupius pirupius Awaiting requested review from pirupius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelmale @brandones @denniskigen