-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Fix Sass version to < 1.65.0 #752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 2.13 MB ℹ️ View Unchanged
|
vasharma05
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Carbon defines a utility Sass function,
rem()
which converts a unit in pixels to a unit in rem; this function is used rather extensively through Carbon's internal Sass files. With 1.65.0, Sass added support for a number of CSS calculation functions, including one rather unfortunately calledrem()
, which calculates the remainder that results from dividing two integers, so most previous versions of Carbon are now incompatible with the 1.65.0 version of Sass. This attempts to fix the version of Sass to < 1.65.0 until Carbon comes up with a release that runs on 1.65.0 (pending as 11.36.0) at which point, we should upgrade.Screenshots
Related Issue
Other