-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-2883: Use toast notifications for system-generated error messages #937
Conversation
Size Change: -740 kB (-21%) 🎉 Total Size: 2.86 MB
ℹ️ View Unchanged
|
@denniskigen @ibacher @usamaidrsk I have pushed the changes, please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hadijahkyampeire!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about these translation strings? Should we remove them from the diff, @ibacher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed them because it looks like they shouldn't be deleted based on https://github.com/openmrs/openmrs-esm-core/pull/938/files.
9daaca0
to
7470d81
Compare
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This makes it so that system-generated error messages render toast notifications instead of inline notifications per the notifications design guidelines.
Before
After
Related Issue
https://openmrs.atlassian.net/browse/O3-2883