Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Only auto-generate English translations #25

Merged
merged 1 commit into from
Feb 19, 2024
Merged

(chore) Only auto-generate English translations #25

merged 1 commit into from
Feb 19, 2024

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jan 31, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

We should only auto-generate translations for English. Translations for non-English languages should come from Transifex.

Screenshots

Related Issue

Other

Josephkagimu1
Josephkagimu1 reviewed Feb 15, 2024
View reviewed changes
Copy link

@Josephkagimu1 Josephkagimu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats great work @ibacher

denniskigen
denniskigen approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ibacher!

@denniskigen denniskigen merged commit 242248b into main Feb 19, 2024
5 checks passed
@denniskigen denniskigen deleted the chore/fix-transifex branch February 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josephkagimu1 Josephkagimu1 Josephkagimu1 left review comments

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibacher @denniskigen @Josephkagimu1