Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Decouple linting and formatting concerns #30

Merged
merged 3 commits into from
May 7, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Our current setup is running Prettier as a part of ESLint. These are two separate concerns that should be handled separately by different tools.

This PR removes eslint-plugin-prettier and eslint-config-prettier from our linting config as recommended here and here. I've also separated ESLint concerns from Prettier so that ESLint doesn't handle both. The recommended modern approach treats Prettier and ESLint as separate unrelated tools.

I've also removed the prettier script from the root-level package.json to the lint-staged config so that lint-staged runs Prettier after ESLint.

Screenshots

Related Issue

Other

@ibacher ibacher merged commit 0afa818 into main May 7, 2024
5 checks passed
@denniskigen denniskigen deleted the chore/lint-and-prettier-tooling branch May 7, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants