Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA-1589: Observations created with style="textarea" are not displayed with newlines. #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ATLCTO
Copy link

@ATLCTO ATLCTO commented May 20, 2019

Observations created with style="textarea" are not displayed with newlines.

Add white-space: pre-wrap so that multi-line text observations are displayed with multiple lines (so they appear the same as they did in the textarea when they were created).

Observations created with style="textarea" are not displayed with newlines.

Add white-space: pre-wrap so that multi-line text observations are displayed with multiple lines (so they appear the same as they did in the textarea when they were created).
Copy link
Member

@isears isears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to narrow down this change to a specific CSS class that would only affect the Observations elements, rather than all span/htmlform/p elements?

@dkayiwa
Copy link
Member

dkayiwa commented Jun 24, 2019

@ATLCTO did you see the above comment?

@dkayiwa
Copy link
Member

dkayiwa commented Jun 30, 2019

@ATLCTO are you still working on this?

@ATLCTO
Copy link
Author

ATLCTO commented Jun 30, 2019

I looked into it when @isears made his first comment and it wasn’t possible to make it more specific as those elements were not decorated with a custom css.

The other way to fix it was a code change (to replace “\n” with “
” in the rendering of the html.

I can submit that change instead of the css change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants