RA-1832: Collection.isEmpty() should be used to test for emptiness #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbertYiga
reviewed
Mar 15, 2021
| @@ -0,0 +1,184 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
There was a problem hiding this comment.
Thanks @dexter808 ,do we nee changes here since we are only replacing .size() with isEmpty()
There was a problem hiding this comment.
Hi @HerbertYiga , I did not touch these files, Maybe these changes were made by the IDE I was using. Is it a problem?
There was a problem hiding this comment.
I did not touch these files, Maybe these changes were made by the IDE I was using. Is it a problem?
only needed changes are the ones to be merged, can you try dropping all the unneeded files for your changes
There was a problem hiding this comment.
Hi @HerbertYiga , sorry for the late reply. I will make a new PR with only the changes that are required.
HerbertYiga
reviewed
Mar 15, 2021
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : https://issues.openmrs.org/browse/RA-1832