Medication Request should return Null when Drug Order has dose units …

…but not dose
openmrs · Feb 22, 2024 · 21b9d33 · 21b9d33
1 parent 952698e
commit 21b9d33
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/api/src/main/java/org/openmrs/module/fhir2/api/translators/impl/DosageTranslatorImpl.java b/api/src/main/java/org/openmrs/module/fhir2/api/translators/impl/DosageTranslatorImpl.java
@@ -51,7 +51,7 @@ public Dosage toFhirResource(@Nonnull DrugOrder drugOrder) {
 		dosage.setRoute(conceptTranslator.toFhirResource(drugOrder.getRoute()));
 		dosage.setTiming(timingTranslator.toFhirResource(drugOrder));
 
-		if (drugOrder.getDose() != null || drugOrder.getDoseUnits() != null) {
+		if (drugOrder.getDose() != null) {
 			Dosage.DosageDoseAndRateComponent doseAndRate = new Dosage.DosageDoseAndRateComponent();
 			Quantity dose = new SimpleQuantity();
 			dose.setValue(drugOrder.getDose());
@@ -66,7 +66,7 @@ public Dosage toFhirResource(@Nonnull DrugOrder drugOrder) {
 			doseAndRate.setDose(dose);
 			dosage.addDoseAndRate(doseAndRate);
 		}
-		
+
 		return dosage;
 	}
 

diff --git a/...src/test/java/org/openmrs/module/fhir2/api/translators/impl/DosageTranslatorImplTest.java b/...src/test/java/org/openmrs/module/fhir2/api/translators/impl/DosageTranslatorImplTest.java
@@ -14,12 +14,17 @@
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.notNullValue;
 import static org.hamcrest.Matchers.nullValue;
+import static org.hl7.fhir.r4.utils.client.FHIRToolingClient.DATE_FORMAT;
 import static org.junit.Assert.assertNull;
 import static org.mockito.Mockito.when;
 
+import java.text.ParseException;
 import java.util.Arrays;
+import java.util.Calendar;
+import java.util.Date;
 import java.util.Locale;
 
+import org.apache.commons.lang3.time.DateUtils;
 import org.hl7.fhir.r4.model.BooleanType;
 import org.hl7.fhir.r4.model.CodeableConcept;
 import org.hl7.fhir.r4.model.Coding;
@@ -211,6 +216,23 @@ public void toFhirResource_shouldTranslateDrugOrderDoseToDoseQuantity() {
 		assertThat(result.getDoseAndRate().get(0).getDoseQuantity().getCode(), is(CONCEPT_UUID));
 	}
 
+	@Test
+	public void toFhirResource_shouldReturnDosageWhenSubmittingDrugOrderWithDoseUnitButNoDose() throws ParseException {
+		Concept mg = new Concept();
+		mg.addName(new ConceptName("mg", Locale.ENGLISH));
+		mg.setUuid(CONCEPT_UUID);
+
+		drugOrder.setDose(null);
+		drugOrder.setDoseUnits(mg);
+		drugOrder.setAsNeeded(Boolean.TRUE);
+		drugOrder.setDosingInstructions(DOSING_INSTRUCTION);
+		Dosage result = dosageTranslator.toFhirResource(drugOrder);
+
+		assertThat(result, notNullValue());
+		assertThat(result.getAsNeededBooleanType().booleanValue(), is(true));
+		assertThat(result.getText(), equalTo(DOSING_INSTRUCTION));
+	}
+
 	@Test
 	public void toFhirResource_shouldTranslateDrugOrderDoseToDoseQuantityPreferringRxNormIfPresent() {
 		ConceptMapType sameAs = new ConceptMapType();