Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM2-602: Add support for XML PATCHing operations - Encounter Resource #506

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mherman22
Copy link
Member

@mherman22 mherman22 commented Jul 11, 2023

Description of what I changed

This ticket introduces XML PATCH operations on the Encounter Resource.

For example the following xml doc should be supported:

<diff xmlns:fhir="http://hl7.org/fhir"> 
   <replace sel="/fhir:Encounter/fhir:period/fhir:start/@value">                  
        2005-02-01T00:00:00+05:30       
   </replace>
</diff>

Issue I worked on

see https://issues.openmrs.org/browse/FM2-602

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 82.61% and no project coverage change.

Comparison is base (42b8c45) 77.24% compared to head (7d2db0c) 77.25%.

❗ Current head 7d2db0c differs from pull request most recent head 849f6c3. Consider uploading reports for the commit 849f6c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #506   +/-   ##
=========================================
  Coverage     77.24%   77.25%           
+ Complexity     2648     2647    -1     
=========================================
  Files           246      246           
  Lines          7426     7423    -3     
  Branches        911      910    -1     
=========================================
- Hits           5736     5734    -2     
  Misses         1142     1142           
+ Partials        548      547    -1     
Impacted Files Coverage Δ
...mrs/module/fhir2/api/impl/FhirTaskServiceImpl.java 71.43% <ø> (ø)
...translators/impl/BaseServiceRequestTranslator.java 0.00% <0.00%> (ø)
...g/openmrs/module/fhir2/api/util/XmlPatchUtils.java 0.00% <ø> (ø)
...ers/r4/AllergyIntoleranceFhirResourceProvider.java 73.91% <0.00%> (ø)
...r2/providers/r4/ConditionFhirResourceProvider.java 60.87% <ø> (ø)
...ir2/providers/r4/LocationFhirResourceProvider.java 72.73% <ø> (ø)
...fhir2/providers/r4/PersonFhirResourceProvider.java 71.43% <ø> (ø)
...odule/fhir2/api/search/param/TaskSearchParams.java 73.33% <91.67%> (ø)
.../api/translators/impl/EncounterTranslatorImpl.java 90.70% <100.00%> (ø)
...translators/impl/ServiceRequestTranslatorImpl.java 95.35% <100.00%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ibacher ibacher merged commit a663faa into openmrs:master Jul 21, 2023
4 checks passed
@mherman22 mherman22 deleted the FM2-602 branch August 2, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants