FM2-605: Add Support for ETags in the FHIR API #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
============================================
+ Coverage 77.06% 77.18% +0.13%
- Complexity 2673 2678 +5
============================================
Files 249 249
Lines 7480 7508 +28
Branches 912 913 +1
============================================
+ Hits 5764 5795 +31
Misses 1164 1164
+ Partials 552 549 -3
☔ View full report in Codecov by Sentry. |
|
@ibacher should I include other resources here? It looks already too big for my liking 😐!!! |
I think so... It's a pretty small series of related changes. Makes sense to have it as one PR and one commit (when merged). |
ibacher
approved these changes
Jul 28, 2023
ibacher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
The purpose here is to trigger HAPI FHIR's support for FHIR's ETag spec using weak ETag's for the version id.
Note that this algorithm could result in the FHIR API reporting a changed ETag where the REST API does not. This is because in the FHIR API the ETag / versionId is derived entirely from the lastUpdated timestamp.
This pull request adds support for etags on all resources supported by the
openmrs fhir2 moduleIssue I worked on
see https://issues.openmrs.org/browse/FM2-605
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master