Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM2-631: HumanName.text should use the NameTemplate #534

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jan 12, 2024

Description of what I changed

HumanName.text is now set to the Person.getFullName() value, which uses the default name template.

Issue I worked on

see https://issues.openmrs.org/browse/FM2-631

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@itstanany
Copy link

Thanks for submitting this pull request! It's great to see a contribution that aims to simplify how human names are displayed.

This change clarifies how HumanName.text is populated by leveraging the Person.getFullName() method. This approach ensures consistency by utilizing the established default name template.
What about adding documentation for this

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (f0b0c35) to head (3fc2043).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #534   +/-   ##
=========================================
  Coverage     77.84%   77.84%           
  Complexity     2682     2682           
=========================================
  Files           239      239           
  Lines          7451     7452    +1     
  Branches        901      901           
=========================================
+ Hits           5800     5801    +1     
  Misses         1115     1115           
  Partials        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibacher ibacher merged commit c7f2ec2 into master Apr 1, 2024
4 checks passed
@ibacher ibacher deleted the FM2-631 branch April 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants