FM2-645: Remove identifier from Practitioner display field #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
============================================
+ Coverage 77.84% 78.66% +0.81%
+ Complexity 2683 2393 -290
============================================
Files 239 236 -3
Lines 7452 7023 -429
Branches 901 921 +20
============================================
- Hits 5801 5524 -277
+ Misses 1115 972 -143
+ Partials 536 527 -9 ☔ View full report in Codecov by Sentry. |
ibacher
requested changes
Oct 1, 2024
Comment on lines
136
to
139
| if (provider.getIdentifier() != null) { | ||
| reference.setIdentifier(new Identifier().setValue(provider.getIdentifier())); | ||
| sb.append(" (").append(FhirConstants.IDENTIFIER).append(": ").append(provider.getIdentifier()).append(")"); | ||
| } |
There was a problem hiding this comment.
Why did we remove this whole block? The ticket was just to get rid of the text display. The reference identifier should still be set.
There was a problem hiding this comment.
Yeah you are right seems like I overlooked the setIdentifier statement and removed the whole block.
Have fixed it now. Thanks for pointing this out.
api/src/test/java/org/openmrs/module/fhir2/api/search/EncounterSearchQueryTest.java
Outdated
Show resolved
Hide resolved
VaishSiddharth
force-pushed
the
fm2-645
branch
from
0dae571
to
d52f415
Compare
VaishSiddharth
changed the title
ibacher
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/FM2-645
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master