-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving source to components #625
Conversation
@odscrachel - this looks good. I'm going to hold off approving it until #623 is merged... since I think it'll be easier to deal with the merge conflicts here. |
@odscrachel - I've merged #623 so there are some conflicts here that need to be resolved. I can do that with you if helpful, since I'll recognise the edits that you'll need to accept. |
@kd-ods ready to review again, the conflicts were the main changes in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolving the merge conflicts meant accepting the new description and title edits for the Source object in its old position in statement.json. So you'll see that the Source object in its new position in components.json still has the old text.
I've made suggested edits to fix that.
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - this can be merged now :-)
Overview
Move source from defs to components file
Update person record and statement files to point to components for source
Check that it looks valid and that we haven't missed source pointers anywhere else
@kd-ods
Closes #622
Translations
translating. See: https://openownership.github.io/bods-dev-handbook/translations.html
Documentation & Release
https://openownership.github.io/bods-dev-handbook/standard_releases.html