Admin menu and controller sections #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microstudi
reviewed
Apr 3, 2024
app/controllers/decidim/anonymous_codes/admin/code_groups_controller.rb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 5, 2024
microstudi
reviewed
Apr 5, 2024
microstudi
reviewed
Apr 5, 2024
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 5, 2024
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 5, 2024
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 5, 2024
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 10, 2024
microstudi
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Nice job Elvia,
you will see that I've left some comments with some improvements.
Also, there's two tests missing that should be added:
- add a spec/forms/admin/code_group_form_spec.rb with tests for the validations included in the form.
- In the system spec, there's a case when the application throws a 500 error. This is when the group has no expiration date defined (there is one comment for it). So we need to add a test case with the expiration date set to nil and check that the views work correctly.
Thanks!
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
app/views/decidim/anonymous_codes/admin/code_groups/index.html.erb
Outdated
Show resolved
Hide resolved
microstudi
reviewed
Apr 12, 2024
microstudi
reviewed
Apr 15, 2024
microstudi
reviewed
Apr 15, 2024
microstudi
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
fixes #2
📷 Screenshots
Index
New
Edit