-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pdf editor and uploader #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microstudi
changed the title
prevent changing document if annotations. Remove sections if not
fix pdf editor and uploader
Jun 20, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 90.15% 94.25% +4.09%
==========================================
Files 64 64
Lines 1361 1374 +13
==========================================
+ Hits 1227 1295 +68
+ Misses 134 79 -55
☔ View full report in Codecov by Sentry. |
# Conflicts: # app/controllers/decidim/participatory_documents/admin/documents_controller.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stadtluzern/decidim-pdf-consultations#42
Fix when deleting a document and uploading another, the boxes from the old document still apear
Fix enlarge/make smaller not working properly: Chrome compatiblity
Fix moving is only possible in the left corner, this is not found intuitively: Chrome compatibilty
Fix sometimes deleted "boxes" are still visible in the front end: When removing a box, if you click "save changes", boxes are restored.
Fix. automatic numbering of boxes on any action: move, add, remove. Order by page, y position, x position