Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pdf editor and uploader #92

Merged
merged 19 commits into from
Jul 7, 2023
Merged

fix pdf editor and uploader #92

merged 19 commits into from
Jul 7, 2023

Conversation

microstudi
Copy link
Contributor

@microstudi microstudi commented Jun 20, 2023

Fixes stadtluzern/decidim-pdf-consultations#42

  • Fix when deleting a document and uploading another, the boxes from the old document still apear

    • Prevent modifying Document if suggestions exist
    • Remove sections & boxes when modifying document if no suggestions
    • Better texts in uploader
      image
  • Fix enlarge/make smaller not working properly: Chrome compatiblity

  • Fix moving is only possible in the left corner, this is not found intuitively: Chrome compatibilty

  • Fix sometimes deleted "boxes" are still visible in the front end: When removing a box, if you click "save changes", boxes are restored.

  • Fix. automatic numbering of boxes on any action: move, add, remove. Order by page, y position, x position

    • Javascript auto-numbering
    • Add position for annotations & sections in DB
    • Reorder position for annotations & sections on save or destroy something (backend)

@microstudi microstudi changed the title prevent changing document if annotations. Remove sections if not fix pdf editor and uploader Jun 20, 2023
@microstudi microstudi self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: +4.09 🎉

Comparison is base (8232f2b) 90.15% compared to head (bbe6db2) 94.25%.

❗ Current head bbe6db2 differs from pull request most recent head 6da69f6. Consider uploading reports for the commit 6da69f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   90.15%   94.25%   +4.09%     
==========================================
  Files          64       64              
  Lines        1361     1374      +13     
==========================================
+ Hits         1227     1295      +68     
+ Misses        134       79      -55     
Impacted Files Coverage Δ
...cidim/participatory_documents/create_suggestion.rb 69.23% <0.00%> (+69.23%) ⬆️
.../models/decidim/participatory_documents/section.rb 100.00% <ø> (ø)
...atory_documents/document_suggestions_controller.rb 95.23% <75.00%> (+23.80%) ⬆️
...articipatory_documents/admin/destroy_annotation.rb 93.10% <100.00%> (+0.24%) ⬆️
...m/participatory_documents/admin/update_document.rb 94.28% <100.00%> (+7.32%) ⬆️
...ory_documents/admin/update_or_create_annotation.rb 95.00% <100.00%> (+0.12%) ⬆️
...ticipatory_documents/admin/documents_controller.rb 88.13% <100.00%> (+0.63%) ⬆️
...patory_documents/section_suggestions_controller.rb 95.23% <100.00%> (+23.80%) ⬆️
...m/participatory_documents/admin/annotation_form.rb 100.00% <100.00%> (ø)
...dels/decidim/participatory_documents/annotation.rb 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paarals paarals added bug Something isn't working boxing-bugs labels Jun 21, 2023
@microstudi microstudi merged commit 467591b into main Jul 7, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boxing-bugs bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BF3. "Boxing-Bugs" while preparing the participatory areas
2 participants