Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

braised-babbage
Copy link
Collaborator

@braised-babbage braised-babbage commented Dec 5, 2022

This adds a CODEOWNERS file, which we can use to notify appropriate people of PRs.

From the docs linked above,

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Code owners are not automatically requested to review draft pull requests. For more information about draft pull requests, see "About pull requests." When you mark a draft pull request as ready for review, code owners are automatically notified. If you convert a pull request to a draft, people who are already subscribed to notifications are not automatically unsubscribed. For more information, see "Changing the stage of a pull request."

At the moment, I am just adding "global" owners. The two listed owners reflect representatives from two organizations using OpenPulse. The working group may wish to add others.

Every code owner must have write access to the repository. So we will need to provide that access to @jcjaskula-aws

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the set of owners but seems nice to have. Also happy to have myself added although I'm watching the whole repository in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants