Be explicit about openqasm3.ast imports #34
Merged
+179
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes imports from
openqasm3.ast
explicit, and does not importCalibrationStatement
orCalibrationDefinition
. These definitions were previously shadowed by subsequent entries inopenpulse.ast
, but this causes a problem formypy
, since the field types of the shadowing definitions disagree with the original field annotations.For example, with the previous implementation, the following program would fail to type check
The
mypy
error isThe
variable has type "str"
comes from theopenqasm3.ast.CalibrationDefinition
, which does usestr
for thebody
field.This closes #35