Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modified the cache objects. We were not caching the ast nodes anymore but the ouput of
to_cached_oqpy_expression
. This led to regression in benchmarks.Solution: we store the ast in
Program.expr_cache
. I changedto_cached_oqpy_expression
return type to beAstConvertible
to matchto_oqpy_expression
. Consequently, we need to call the mainto_ast
function instead ofHasToAst.to_ast
.Updated a unit test.