Fixes serialization issues with Exception#cause [rework] #3229
Conversation
| static Throwable exceptionWithoutSelfReferences(Throwable throwable) { | ||
| // remove self-references from the cause chain to avoid serialization problems from the Moderne plugins | ||
| Throwable temp = throwable; | ||
| do { | ||
| if (temp.getCause() == null) { | ||
| try { | ||
| temp.initCause(null); | ||
| } catch (IllegalStateException ignored) { | ||
| //ignore, the cause was already initialized to null | ||
| } | ||
| break; | ||
| } | ||
| } while ((temp = temp.getCause()) != null); | ||
|
|
||
| return throwable; | ||
| } |
There was a problem hiding this comment.
Isn't this a rendering issue, not an issue in the Markup.Warn creation problem? This seems like something that should be fixed in rendering or serialization, not by messing with the exception that gets returned by the AST.
Basically, this looks like you're fixing the wrong problem
There was a problem hiding this comment.
AFAICT the serialization problem we've seen is due to FasterXML/jackson-databind#1986. I don't know if I understand FasterXML/jackson-databind#1986 (comment) correctly, but also looking at FasterXML/jackson-databind#877 it seems like it should be possible to define and register a mixin similar to this:
public abstract class ThrowableMixin {
@JsonIgnore private Throwable cause;
@JsonIgnore public abstract Throwable getCause();
}I don't know if that will work or if it will have the effect of not serializing any of the exception causes.
This being said, I agree with you that it would be better if we could get Jackson to properly serialize exceptions without having to muck with them like this.
There was a problem hiding this comment.
I think that you are right. We can create instead a jackson module to serialize exceptions :)
Closing the PR for now.
There was a problem hiding this comment.
If you find a way to do this, that would be great!
Context: #3199
I merged assuming that GH Actions run in the previous commit, but there were tests errors. So I reverted the commit and this PR fixes the tests errors.