-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support OSG 24 in GHAs #21
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this LGTM but I'm not sure if we want to continue supporting latest
and release
, testing
, and development
tags. What do you think @matyasselmeci ?
Maybe we just leave those at OSG 23 with similar reasoning that we shouldn't have a latest tarball CVMFS symlink that crosses release series boundaries.
If we leave
(these options apply to We should definitely discourage the use of the series-less tags. The README needs updating badly anyway. Note that the pull command shown on the Docker Hub page doesn't include a tag (so it's implicitly |
Comedy option 4: point latest at 25-el10-development. Hey, you wanted latest. |
I vote (3) and we put up admonitions in our docs to tell people that |
[[ $OSG_RELEASE == '23' ]] && tags+=( $registry/$docker_repo:latest ) | ||
[[ $OSG_RELEASE == '24' ]] && tags+=( $registry/$docker_repo:latest ) | ||
else | ||
[[ $OSG_RELEASE == '23' ]] && tags+=( $registry/$docker_repo:$BASE_YUM_REPO ) | ||
[[ $OSG_RELEASE == '24' ]] && tags+=( $registry/$docker_repo:$BASE_YUM_REPO ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert these changes since I'd like to deprecate these tags
No description provided.