Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support OSG 24 in GHAs #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature: Support OSG 24 in GHAs #21

wants to merge 2 commits into from

Conversation

mwestphall
Copy link

No description provided.

Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM but I'm not sure if we want to continue supporting latest and release, testing, and development tags. What do you think @matyasselmeci ?

Maybe we just leave those at OSG 23 with similar reasoning that we shouldn't have a latest tarball CVMFS symlink that crosses release series boundaries.

@matyasselmeci
Copy link
Contributor

If we leave latest, release, etc. at OSG 23, then we need to decide what happens when OSG 23 goes out of support -- we could

  1. Leave latest at 23 forever, and stop updating it
  2. Change the series of latest (to what? 24 or 25? In theory both will be out by then)
  3. Delete latest

(these options apply to release, testing, development as well)

We should definitely discourage the use of the series-less tags. The README needs updating badly anyway. Note that the pull command shown on the Docker Hub page doesn't include a tag (so it's implicitly latest) and I couldn't find a way to change that.

@matyasselmeci
Copy link
Contributor

Comedy option 4: point latest at 25-el10-development. Hey, you wanted latest.

@brianhlin
Copy link
Member

I vote (3) and we put up admonitions in our docs to tell people that latest, development, release, and testing tags are deprecated

Comment on lines -49 to +60
[[ $OSG_RELEASE == '23' ]] && tags+=( $registry/$docker_repo:latest )
[[ $OSG_RELEASE == '24' ]] && tags+=( $registry/$docker_repo:latest )
else
[[ $OSG_RELEASE == '23' ]] && tags+=( $registry/$docker_repo:$BASE_YUM_REPO )
[[ $OSG_RELEASE == '24' ]] && tags+=( $registry/$docker_repo:$BASE_YUM_REPO )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert these changes since I'd like to deprecate these tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants