Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding (v)host configurable for STOMP protocol #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rob-c
Copy link

@rob-c rob-c commented May 18, 2022

I found I had to configure the vhost of the STOMP connection in order to connect to a RabbitMQ server at Edinburgh.

I don't know if it's common/best-practice to have a vhost which is the IP of the host associated with the MQ (this is the default from the go library) but I'm aware of a few use-cases where this has not been the case in a setup, hence I've made it configurable.

I've just added a host parameter to the config so that it's picked up and passed onto RabbitMQ correctly. I think this is probably best as a string, but I can't think of a sensible default to add here other than the rabbitmq one of '/' if it's worth making this an optional config parameter.

Happy to change this to 'vhost' rather than 'host' if having this and a url might cause some confusion.

@djw8605
Copy link
Member

djw8605 commented May 18, 2022

Yes, I think changing it to vhost to be more explicit is good. I also noticed it's not in the example configuration, could you put it in the example config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants