Fix duplicate i18n identifiers in visualize plugin (#8407)

* Fix duplicate i18n identifiers in visualize plugin Signed-off-by: Miki <[email protected]> * Changeset file for PR #8407 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-project · Oct 1, 2024 · 2e7e235 · 2e7e235
1 parent 0f126da
commit 2e7e235
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/changelogs/fragments/8407.yml b/changelogs/fragments/8407.yml
@@ -0,0 +1,2 @@
+fix:
+- Fix duplicate i18n identifiers in visualize plugin ([#8407](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8407))
diff --git a/src/plugins/visualize/public/application/components/visualize_listing.tsx b/src/plugins/visualize/public/application/components/visualize_listing.tsx
@@ -89,15 +89,15 @@ export const VisualizeListing = () => {
     if (showUpdatedUx) {
       chrome.setBreadcrumbs([
         {
-          text: i18n.translate('visualize.visualizeListingBreadcrumbsTitle', {
+          text: i18n.translate('visualize.listingBreadcrumbsTitle', {
             defaultMessage: 'Visualizations',
           }),
         },
       ]);
     } else {
       chrome.setBreadcrumbs([
         {
-          text: i18n.translate('visualize.visualizeListingBreadcrumbsTitle', {
+          text: i18n.translate('visualize.legacy.listingBreadcrumbsTitle', {
             defaultMessage: 'Visualize',
           }),
         },

diff --git a/src/plugins/visualize/public/application/components/visualize_top_nav.tsx b/src/plugins/visualize/public/application/components/visualize_top_nav.tsx
@@ -261,7 +261,7 @@ const TopNav = ({
       indexPatterns={indexPatterns}
       screenTitle={
         vis.title ||
-        i18n.translate('discover.savedSearch.newTitle', {
+        i18n.translate('visualize.savedSearch.newTitle', {
           defaultMessage: 'New visualization',
         })
       }

diff --git a/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx b/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx
@@ -106,7 +106,7 @@ export const getLegacyTopNavConfig = (
     {
       id: 'inspector',
       label: i18n.translate('visualize.topNavMenu.openInspectorButtonLabel', {
-        defaultMessage: 'inspect',
+        defaultMessage: 'Inspect',
       }),
       description: i18n.translate('visualize.topNavMenu.openInspectorButtonAriaLabel', {
         defaultMessage: 'Open Inspector for visualization',
@@ -127,7 +127,7 @@ export const getLegacyTopNavConfig = (
     {
       id: 'share',
       label: i18n.translate('visualize.topNavMenu.shareVisualizationButtonLabel', {
-        defaultMessage: 'share',
+        defaultMessage: 'Share',
       }),
       description: i18n.translate('visualize.topNavMenu.shareVisualizationButtonAriaLabel', {
         defaultMessage: 'Share Visualization',
@@ -168,10 +168,10 @@ export const getLegacyTopNavConfig = (
             label:
               savedVis?.id && originatingApp
                 ? i18n.translate('visualize.topNavMenu.saveVisualizationAsButtonLabel', {
-                    defaultMessage: 'save as',
+                    defaultMessage: 'Save as',
                   })
                 : i18n.translate('visualize.topNavMenu.saveVisualizationButtonLabel', {
-                    defaultMessage: 'save',
+                    defaultMessage: 'Save',
                   }),
             emphasize: (savedVis && !savedVis.id) || !originatingApp,
             description: i18n.translate('visualize.topNavMenu.saveVisualizationButtonAriaLabel', {