-
Notifications
You must be signed in to change notification settings - Fork 872
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add i18n checks to PR workflows (#8411)
* Ignore missing `formats` while checking locale files Also: * Add help text and description to `i18n-check` * Fix malformed translations Signed-off-by: Miki <[email protected]> * Add i18n checks to PR workflows Signed-off-by: Miki <[email protected]> * Changeset file for PR #8411 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
- Loading branch information
1 parent
e077644
commit 428a7c2
Showing
12 changed files
with
103 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ env: | |
NODE_OPTIONS: '--max-old-space-size=6144 --dns-result-order=ipv4first' | ||
|
||
jobs: | ||
build-lint-test: | ||
build-test: | ||
name: Build and Verify on ${{ matrix.name }} (ciGroup${{ matrix.group }}) | ||
strategy: | ||
fail-fast: false | ||
|
@@ -104,18 +104,6 @@ jobs: | |
if: matrix.os == 'windows-latest' | ||
run: yarn osd bootstrap || yarn osd bootstrap | ||
|
||
- name: Run linter | ||
# ciGroup 1 of unit-tests is shorter and Linux is faster | ||
if: matrix.group == 1 && matrix.os == 'ubuntu-latest' | ||
id: linter | ||
run: yarn lint | ||
|
||
- name: Validate NOTICE file | ||
# ciGroup 1 of unit-tests is shorter and Linux is faster | ||
if: matrix.group == 1 && matrix.os == 'ubuntu-latest' | ||
id: notice-validate | ||
run: yarn notice:validate | ||
|
||
- name: Run unit tests group ${{ matrix.group }} with coverage | ||
id: unit-tests | ||
run: yarn test:jest:ci:coverage --ci-group=${{ matrix.group }} | ||
|
@@ -140,6 +128,51 @@ jobs: | |
id: integration-tests | ||
run: yarn test:jest_integration:ci | ||
|
||
lint-and-validate: | ||
name: Lint and validate | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version-file: '.nvmrc' | ||
registry-url: 'https://registry.npmjs.org' | ||
|
||
- name: Setup Yarn | ||
run: | | ||
npm uninstall -g yarn | ||
npm i -g [email protected] | ||
yarn config set network-timeout 1000000 -g | ||
- name: Configure Yarn Cache | ||
run: echo "YARN_CACHE_LOCATION=$(yarn cache dir)" >> $GITHUB_ENV | ||
|
||
- name: Initialize Yarn Cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: ${{ env.YARN_CACHE_LOCATION }} | ||
key: yarn-${{ hashFiles('**/yarn.lock') }} | ||
restore-keys: | | ||
yarn- | ||
- name: Run bootstrap | ||
run: yarn osd bootstrap | ||
|
||
- name: Run linter | ||
id: linter | ||
run: yarn lint | ||
|
||
- name: Validate NOTICE file | ||
id: notice-validate | ||
run: yarn notice:validate | ||
|
||
- name: Check i18n | ||
id: i18n-check | ||
run: yarn i18n:check | ||
|
||
functional-tests: | ||
name: Run functional tests on ${{ matrix.name }} (ciGroup${{ matrix.group }}) | ||
strategy: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
infra: | ||
- Add i18n checks to PR workflows ([#8411](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8411)) | ||
|
||
feat: | ||
- Ignore missing `formats` while checking locale files ([#8411](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8411)) | ||
- Add help text and description to `i18n-check` ([#8411](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8411)) | ||
|
||
fix: | ||
- Fix malformed translations ([#8411](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8411)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters