Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Deprecate the apiVersion: master value and replace with main #1799

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

manasvinibs
Copy link
Member

Signed-off-by: Manasvini B Suryanarayana [email protected]

Description

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.

In this change, we are replacing 'apiVersion: master' with 'apiVersion:main'.

Issues Resolved

#1687

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on workflows to finish

* Version of the OpenSearch (6.7, 7.1 or `master`) client will be connecting to.
* Version of the OpenSearch (6.7, 7.1 or `main`) client will be connecting to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - we should change the version examples while we're editing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@kavilla kavilla merged commit 2e6293e into opensearch-project:main Jun 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
… main (#1799)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit 2e6293e)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
… main (#1799)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit 2e6293e)
kavilla pushed a commit that referenced this pull request Jun 29, 2022
… main (#1799) (#1831)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit 2e6293e)

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
kavilla pushed a commit that referenced this pull request Jul 5, 2022
… main (#1799) (#1830)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit 2e6293e)

Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate the apiVersion: master value and replace with ?
3 participants