Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Add lazy loading to enable all the services for canvas #4432

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/data_explorer/public/components/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const DataExplorerApp = ({ basename, history }: DataExplorerAppDeps) => {
restrictWidth={false}
paddingSize="none"
>
{view.ui.canvas}
<React.Suspense fallback={<div>Loading...</div>}>{view.ui.canvas}</React.Suspense>
</EuiPageTemplate>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
*/

import React from 'react';
import { DiscoverCanvas } from './discover_canvas';

export const createCanvas = () => {
return <div>Test Canvas</div>;
const LazyDiscoverCanvas = React.lazy(DiscoverCanvas);

Check warning on line 10 in src/plugins/discover/public/application/view_components/canvas/create_canvas.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/discover/public/application/view_components/canvas/create_canvas.tsx#L10

Added line #L10 was not covered by tests

return (

Check warning on line 12 in src/plugins/discover/public/application/view_components/canvas/create_canvas.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/discover/public/application/view_components/canvas/create_canvas.tsx#L12

Added line #L12 was not covered by tests
<React.Suspense fallback={<div>Loading...</div>}>
<LazyDiscoverCanvas />
</React.Suspense>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

import React from 'react';
import { getServices } from '../../../opensearch_dashboards_services';

export const DiscoverCanvas = async () => {
const services = await getServices();

Check warning on line 10 in src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx#L10

Added line #L10 was not covered by tests

if (!services) {
return { default: () => <div>Test Canvas</div> };

Check warning on line 13 in src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx#L13

Added line #L13 was not covered by tests
}
return { default: () => <div>Test Canvas has services</div> };

Check warning on line 15 in src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/discover/public/application/view_components/canvas/discover_canvas.tsx#L15

Added line #L15 was not covered by tests
};
Loading