Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS18 Upgrade] Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections #4948

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 6, 2023

Description

[NodeJS18 Upgrade] Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections

Issues Resolved

opensearch-project/opensearch-build#1563
opensearch-project/opensearch-build#3743

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@peterzhuamazon peterzhuamazon self-assigned this Sep 6, 2023
@peterzhuamazon peterzhuamazon changed the title Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog Sep 6, 2023
@peterzhuamazon peterzhuamazon changed the title Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections Sep 6, 2023
@peterzhuamazon peterzhuamazon changed the title Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections [NodeJS18 Upgrade] Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections Sep 6, 2023
@peterzhuamazon peterzhuamazon added >upgrade release nodejs 🍭 issues related to nodejs client v2.10.0 labels Sep 6, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this file and I would love to get rid of it; if Infra uses it for anything, let's work together and change them to use .nvmrc instead and then remove this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use this file at all.
But I would say probably remove in main before remove in 2.x.

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah probably worth merit to open an issue @AMoo-Miki to verify usage of this.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #4948 (d6cf6a4) into 2.x (1d2987f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4948   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3399     3399           
  Lines       64881    64881           
  Branches    10360    10360           
=======================================
  Hits        43107    43107           
  Misses      19215    19215           
  Partials     2559     2559           
Flag Coverage Δ
Linux_1 34.91% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_3 44.20% <ø> (ø)
Linux_4 35.09% <ø> (ø)
Windows_1 34.92% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.20% <ø> (ø)
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kavilla kavilla merged commit 2b167df into opensearch-project:2.x Sep 6, 2023
78 checks passed
@peterzhuamazon peterzhuamazon deleted the nodejs18-bump-2.10-version branch September 6, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nodejs 🍭 issues related to nodejs client release >upgrade v2.10.0
Projects
Development

Successfully merging this pull request may close these issues.

4 participants