-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource]set fixed totalcount number for empty state #6561
Conversation
Signed-off-by: yujin-emma <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: yujin-emma <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
ciGroup3 failure is not related to code change in this PR |
...ublic/application/components/dashboard_listing/__snapshots__/dashboard_listing.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/no_data_source/no_data_source.tsx
Outdated
Show resolved
Hide resolved
…ource/no_data_source.tsx Co-authored-by: Zhongnan Su <[email protected]> Signed-off-by: Yu Jin <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Description
Set the total count as 0 in empty state component instead of using extra props
Issues Resolved
#6562
Screenshot
Testing the changes
DataSourceAggregatedView - List active
DataSourceAggregatedView - List all
DataSourceView
DataSourceSelectable
DataSourceMultiSelect
Changelog
Check List
yarn test:jest
yarn test:jest_integration