Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource]set fixed totalcount number for empty state #6561

Closed
wants to merge 7 commits into from

Conversation

yujin-emma
Copy link
Contributor

@yujin-emma yujin-emma commented Apr 19, 2024

Description

Set the total count as 0 in empty state component instead of using extra props

Issues Resolved

#6562

Screenshot

Testing the changes

DataSourceAggregatedView - List active
list-active

DataSourceAggregatedView - List all
list-all

DataSourceView
data-source-view

DataSourceSelectable
selectable

DataSourceMultiSelect
multi-select

Changelog

  • fix: Set fixed totalcount number for empty state

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: yujin-emma <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@yujin-emma
Copy link
Contributor Author

src/plugins/dashboard/public/application/components/dashboard_listing/dashboard_listing.test.tsx
Debugger listening on ws://127.0.0.1:53952/1c73741b-e44c-4e40-ac64-d42d9daa95b5
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
yarn run v1.22.19
$ scripts/use_node scripts/jest src/plugins/dashboard/public/application/components/dashboard_listing/dashboard_listing.test.tsx
Debugger listening on ws://127.0.0.1:53233/ec901f83-7176-4fe9-9533-162727657736
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
ciGroups []
jest-haste-map: duplicate manual mock found: index
  The following files share their name; please delete one of them:
    * <rootDir>/src/plugins/vis_type_vega/public/expressions/__mocks__/index.ts
    * <rootDir>/src/core/server/saved_objects/import/__mocks__/index.ts

 PASS  src/plugins/dashboard/public/application/components/dashboard_listing/dashboard_listing.test.tsx (5.455 s)
  dashboard listing
    ✓ renders table rows (141 ms)
    ✓ renders call to action when no dashboards exist (23 ms)
    ✓ hideWriteControls (47 ms)
    ✓ renders warning when listingLimit is exceeded (63 ms)
    ✓ render table listing with initial filters from URL (51 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total
Snapshots:   5 passed, 5 total
Time:        6.103 s

ciGroup3 failure is not related to code change in this PR

yujin-emma and others added 2 commits April 19, 2024 16:23
…ource/no_data_source.tsx

Co-authored-by: Zhongnan Su <[email protected]>
Signed-off-by: Yu Jin <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
@kavilla kavilla linked an issue Apr 21, 2024 that may be closed by this pull request
@yujin-emma yujin-emma closed this Apr 22, 2024
@yujin-emma yujin-emma deleted the header-broken branch April 22, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get the number of data source for empty state for aggregated view
2 participants