[Workspace]fix the UI of menu content picker #8138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
|
@Hailong-am Hi, thanks for the spotting the error, the issue is solved, please check the screenshot |
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/the_style_of_side_bar_and_menu_content_picker
branch
from
0a09503
to
1ad2dc4
Compare
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/the_style_of_side_bar_and_menu_content_picker
branch
from
4d4a7cd
to
7fa9d13
Compare
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
Qxisylolo
requested review from
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
kavilla
reviewed
Sep 12, 2024
| className="eui-fullHeight" | ||
| hasShadow={false} | ||
| paddingSize="none" | ||
| style={{ width: '280px' }} |
There was a problem hiding this comment.
should we consider a stylesheet? vs inline styles?
@AMoo-Miki @virajsanghvi @zhongnansu is this the proper setting for look and feel?
ruanyl
approved these changes
Sep 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8138 +/- ##
==========================================
+ Coverage 60.58% 60.74% +0.15%
==========================================
Files 3738 3739 +1
Lines 88670 88753 +83
Branches 13782 13811 +29
==========================================
+ Hits 53725 53916 +191
+ Misses 31661 31517 -144
- Partials 3284 3320 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
close as changes are included in #8364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the UI of menu content picker according to feedback
Screenshot
fix: the width will be consistent in non-admin mode
overall appearance
Changelog
Check List
yarn test:jestyarn test:jest_integration