[Workspace] Fix fit&finish for workspace overview page #8139

Hailong-am · 2024-09-11T10:33:09Z

Description

wording change for workspace overview page
getting started card typography using h4 with s size
show recently access & updated assets only for current workspace
hide workspace name in recently assets card when in a workspace
Use doc link service to get links
Recently updated assets use find to search by update_at instead of use recently accessed

Issues Resolved

Screenshot

Untitled.mov

Testing the changes

enable workspace and new home in opensearch_dashboards.yml file

workspace.enabled: true
uiSettings:
  overrides:
    "home:useNewHomePage": true

start OSD with yarn start --no-base-path
create workspace with essential use case
verify content in workspace overview page

Changelog

fix: fix fit & finish for workspace overview getting started and assets section

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-09-12T04:25:05Z

Codecov Report

Attention: Patch coverage is 70.27027% with 22 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (b8b563d) to head (ecf295a).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...nagement/public/management_section/recent_work.tsx	74.60%	5 Missing and 11 partials ⚠️
...nt_management/public/components/section_render.tsx	20.00%	4 Missing ⚠️
...blic/components/card_container/card_embeddable.tsx	0.00%	0 Missing and 1 partial ⚠️
src/plugins/home/public/plugin.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8139   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3750           
  Lines       89054    89095   +41     
  Branches    13910    13923   +13     
=======================================
+ Hits        54257    54285   +28     
- Misses      31433    31436    +3     
- Partials     3364     3374   +10

Flag	Coverage Δ
Linux_1	`28.84% <4.05%> (-0.02%)`	⬇️
Linux_2	`56.35% <ø> (ø)`
Linux_3	`37.72% <5.40%> (-0.03%)`	⬇️
Linux_4	`29.96% <68.91%> (+<0.01%)`	⬆️
Windows_1	`28.85% <4.05%> (-0.02%)`	⬇️
Windows_2	`56.30% <ø> (ø)`
Windows_3	`37.73% <5.40%> (-0.03%)`	⬇️
Windows_4	`29.96% <68.91%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/home/public/application/components/home_list_card.tsx

ruanyl · 2024-09-20T09:27:03Z

src/plugins/home/public/application/components/usecase_overview/search_use_case_setup.tsx

@@ -115,7 +117,7 @@ export const registerContentToSearchUseCasePage = (
    });
  });

-  const searchIcon = <EuiIcon color="subdued" size="l" type="search" />;
+  const searchIcon = <EuiIcon color="#9FC4D2" size="l" type="search" />;


Shall we not hard code the color? Just wondering how it will look like under dark/light mode?

dark mode

light mode

$ouiLinkColor Shall we use this variable?

https://oui.opensearch.org/1.14/#/guidelines/sass

$ouiLinkColor Shall we use this variable?

https://oui.opensearch.org/1.14/#/guidelines/sass

let me see if I can use predefined variables

updated to a custom color by leveraging oui variable color: tint($euiLinkColor, 50%);

src/plugins/saved_objects_management/public/management_section/recent_work.tsx

Signed-off-by: Hailong Cui <[email protected]>

…_page

Signed-off-by: Hailong Cui <[email protected]>

src/plugins/saved_objects_management/public/management_section/recent_work.tsx

src/plugins/content_management/public/services/content_management/types.ts

Signed-off-by: Hailong Cui <[email protected]>

…_page

* fit&finish for workspace overview page Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #8139 created/updated * revert recent_items.tsx change Signed-off-by: Hailong Cui <[email protected]> * use doclink service to build links Signed-off-by: Hailong Cui <[email protected]> * remove commented urls Signed-off-by: Hailong Cui <[email protected]> * update getting started card title size Signed-off-by: Hailong Cui <[email protected]> * update getting started card title size Signed-off-by: Hailong Cui <[email protected]> * recently updated assets Signed-off-by: Hailong Cui <[email protected]> * update card title size Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #8139 created/updated * address review comments Signed-off-by: Hailong Cui <[email protected]> * fix for search overview page Signed-off-by: Hailong Cui <[email protected]> * wrap the card title Signed-off-by: Hailong Cui <[email protected]> * make getting started card not collapseable Signed-off-by: Hailong Cui <[email protected]> * udpate getting started card title size Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 69ec279) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fit&finish for workspace overview page * Changeset file for PR #8139 created/updated * revert recent_items.tsx change * use doclink service to build links * remove commented urls * update getting started card title size * update getting started card title size * recently updated assets * update card title size * Changeset file for PR #8139 created/updated * address review comments * fix for search overview page * wrap the card title * make getting started card not collapseable * udpate getting started card title size * address review comments * address review comments --------- (cherry picked from commit 69ec279) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…oject#8139) (opensearch-project#8386) * fit&finish for workspace overview page * Changeset file for PR opensearch-project#8139 created/updated * revert recent_items.tsx change * use doclink service to build links * remove commented urls * update getting started card title size * update getting started card title size * recently updated assets * update card title size * Changeset file for PR opensearch-project#8139 created/updated * address review comments * fix for search overview page * wrap the card title * make getting started card not collapseable * udpate getting started card title size * address review comments * address review comments --------- (cherry picked from commit 69ec279) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the all-star-contributor label Sep 11, 2024

opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 11, 2024

Changeset file for PR opensearch-project#8139 created/updated

cee7a49

Hailong-am marked this pull request as ready for review September 12, 2024 04:10

kavilla reviewed Sep 12, 2024

View reviewed changes

src/plugins/home/public/application/components/home_list_card.tsx Outdated Show resolved Hide resolved

kavilla previously approved these changes Sep 12, 2024

View reviewed changes

ruanyl added 2.17.1 and removed v2.18.0 labels Sep 19, 2024

Merge branch 'main' into fit_finish_overview_page

a58d19a

ruanyl reviewed Sep 20, 2024

View reviewed changes

src/plugins/saved_objects_management/public/management_section/recent_work.tsx Show resolved Hide resolved

Hailong-am added 9 commits September 20, 2024 19:12

address review comments

f7fe4fa

Signed-off-by: Hailong Cui <[email protected]>

Merge branch 'main' into fit_finish_overview_page

75a939d

Merge branch 'main' into fit_finish_overview_page

3407f48

fix for search overview page

825916c

Signed-off-by: Hailong Cui <[email protected]>

Merge remote-tracking branch 'upstream/main' into fit_finish_overview…

0ca41fa

…_page

wrap the card title

e043ca0

Signed-off-by: Hailong Cui <[email protected]>

make getting started card not collapseable

2de8902

Signed-off-by: Hailong Cui <[email protected]>

udpate getting started card title size

9973518

Signed-off-by: Hailong Cui <[email protected]>

Merge branch 'main' into fit_finish_overview_page

981f421

ruanyl previously approved these changes Sep 29, 2024

View reviewed changes

src/plugins/saved_objects_management/public/management_section/recent_work.tsx Show resolved Hide resolved

SuZhou-Joe reviewed Sep 29, 2024

View reviewed changes

src/plugins/content_management/public/services/content_management/types.ts Outdated Show resolved Hide resolved

SuZhou-Joe previously approved these changes Sep 29, 2024

View reviewed changes

address review comments

81ed6cb

Signed-off-by: Hailong Cui <[email protected]>

Hailong-am dismissed stale reviews from SuZhou-Joe and ruanyl via 81ed6cb September 29, 2024 09:24

Hailong-am added 3 commits September 29, 2024 17:25

Merge branch 'main' into fit_finish_overview_page

14f831a

address review comments

7fd15ee

Signed-off-by: Hailong Cui <[email protected]>

Merge remote-tracking branch 'upstream/main' into fit_finish_overview…

ecf295a

…_page

ruanyl approved these changes Sep 30, 2024

View reviewed changes

SuZhou-Joe approved these changes Sep 30, 2024

View reviewed changes

ruanyl merged commit 69ec279 into opensearch-project:main Sep 30, 2024
65 of 67 checks passed

opensearch-trigger-bot bot mentioned this pull request Sep 30, 2024

[Backport 2.x] [Workspace] Fix fit&finish for workspace overview page #8386

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Fix fit&finish for workspace overview page #8139

[Workspace] Fix fit&finish for workspace overview page #8139

Hailong-am commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading

ruanyl Sep 20, 2024

Hailong-am Sep 20, 2024

SuZhou-Joe Sep 30, 2024

Hailong-am Sep 30, 2024

Hailong-am Sep 30, 2024

[Workspace] Fix fit&finish for workspace overview page #8139

[Workspace] Fix fit&finish for workspace overview page #8139

Conversation

Hailong-am commented Sep 11, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

ruanyl Sep 20, 2024

Choose a reason for hiding this comment

Hailong-am Sep 20, 2024

Choose a reason for hiding this comment

SuZhou-Joe Sep 30, 2024

Choose a reason for hiding this comment

Hailong-am Sep 30, 2024

Choose a reason for hiding this comment

Hailong-am Sep 30, 2024

Choose a reason for hiding this comment

Hailong-am commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading