Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unprefixed and duplicate i18n identifiers in workspace plugin #8410

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Fix unprefixed and duplicate i18n identifiers in workspace plugin

Changelog

  • fix: Fix unprefixed and duplicate i18n identifiers in workspace plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Miki!

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (4b56be5) to head (c7f22ec).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8410   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3750           
  Lines       89104    89104           
  Branches    13926    13926           
=======================================
+ Hits        54284    54286    +2     
+ Misses      31443    31442    -1     
+ Partials     3377     3376    -1     
Flag Coverage Δ
Linux_1 28.83% <100.00%> (ø)
Linux_2 56.35% <ø> (ø)
Linux_3 37.72% <ø> (+<0.01%) ⬆️
Linux_4 29.96% <ø> (ø)
Windows_1 28.84% <100.00%> (ø)
Windows_2 56.30% <ø> (ø)
Windows_3 37.73% <ø> (+<0.01%) ⬆️
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc added the i18n Internationalization related Issues and PRs label Oct 1, 2024
@AMoo-Miki AMoo-Miki merged commit 0f126da into opensearch-project:main Oct 1, 2024
73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8410-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f126da2c8e7bdbf8b8b915e197a4a0aa90ed1ee
# Push it to GitHub
git push --set-upstream origin backport/backport-8410-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8410-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2024
)

Signed-off-by: Miki <[email protected]>
(cherry picked from commit 0f126da)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 7, 2024
) (#8505)

(cherry picked from commit 0f126da)

Signed-off-by: Miki <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants